WIP: Issue-840 #841
WIP: Issue-840 #841
Conversation
requirements/build_windows.txt
Outdated
| numpy==1.15.4 | ||
|
|
There was a problem hiding this comment.
Any reason for the reordering and blank lines? Just curious
There was a problem hiding this comment.
Mostly as a visual aid as I was comparing requirements across files. I do like to have requirements having a similar purpose grouped together though, like the pytest requirements. I can remove the blank lines, or completely revert the file if you'd prefer.
requirements/development.txt
Outdated
| @@ -1,16 +1,16 @@ | |||
| bumpversion==0.5.3 | |||
| Cython==0.29.10 | |||
|
|
|||
There was a problem hiding this comment.
And the reordering and blank lines in this file?
| @@ -4,24 +4,33 @@ envlist=py{35,36,37,38,py3}-marshmallow{2,3}, cython-marshmallow{2,3} | |||
| [testenv] | |||
| deps= | |||
| -rrequirements/build_common.txt | |||
| marshmallow2: marshmallow <3.0 | |||
| marshmallow3: marshmallow==3.0.0rc6 | |||
| marshmallow2: -rrequirements/marshmallow2.txt | |||
There was a problem hiding this comment.
Appreciate the cleanup in this file. Really want your PR merged for this.
|
As far as I can tell, the "testdevelopment" section I added to the tox.ini file is not being run, so I'll need to figure out why before these changes satisfy the requirements in the ticket. |
|
@jbcooley7 Does this help? |
WIP: Testing tox.ini and requirements text file changes since I don't have all the Python versions installed in order to get tox running locally.